Skip to content

gh-139805: Bump test_repl_eio timeout for slow builtbots#139807

Merged
vstinner merged 1 commit into
python:mainfrom
StanFromIreland:long-timeout
Oct 8, 2025
Merged

gh-139805: Bump test_repl_eio timeout for slow builtbots#139807
vstinner merged 1 commit into
python:mainfrom
StanFromIreland:long-timeout

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Oct 8, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Oct 8, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 8, 2025
Closed
@StanFromIreland

StanFromIreland commented Oct 8, 2025

Copy link
Copy Markdown
Member Author

Requested Victor as you previously bumped it.

@vstinner

vstinner commented Oct 8, 2025

Copy link
Copy Markdown
Member

I don't have access to the worker. According to #139805 (comment) it uses currently a timeout of 60 seconds which is already long. Are you sure that a longer timeout will solve the issue?

@StanFromIreland

StanFromIreland commented Oct 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Are you sure that a longer timeout will solve the issue?

With the longer timeout, I was unable to reproduce even under very high load.

Let's run the buildbots.

@StanFromIreland

StanFromIreland commented Oct 8, 2025

Copy link
Copy Markdown
Member Author

!buildbot Raspbian

@bedevere-bot

bedevere-bot commented Oct 8, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @StanFromIreland for commit 850a1b3 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139807%2Fmerge

The command will test the builders whose names match following regular expression: Raspbian

The builders matched are:

  • ARM Raspbian PR
  • ARM64 Raspbian PR
  • ARM Raspbian Linux Asan PR
  • ARM64 Raspbian Debug PR

vstinner
vstinner approved these changes Oct 8, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the longer timeout, I was unable to reproduce even under very high load.

Oh ok. I trust you on the fix in this case ;-)

@vstinner

vstinner commented Oct 8, 2025

Copy link
Copy Markdown
Member

buildbot/ARM64 Raspbian Debug PR — Build done.
buildbot/ARM64 Raspbian PR — Build done.

Tests passed on the two buildbots.

@vstinner vstinner merged commit e7e3d1d into python:main Oct 8, 2025
59 checks passed
@vstinner vstinner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 8, 2025
@miss-islington-app

miss-islington-app Bot commented Oct 8, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Oct 8, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2025
@StanFromIreland @miss-islington
pythongh-139805: Bump test_repl_eio timeout for slow builtbots (pyt…
a49a489 
…honGH-139807)

(cherry picked from commit e7e3d1d)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2025
@StanFromIreland @miss-islington
pythongh-139805: Bump test_repl_eio timeout for slow builtbots (pyt…
c9e0e58 
…honGH-139807)

(cherry picked from commit e7e3d1d)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Oct 8, 2025

Copy link
Copy Markdown

GH-139812 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 8, 2025
@bedevere-app

bedevere-app Bot commented Oct 8, 2025

Copy link
Copy Markdown

GH-139813 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Oct 8, 2025
@vstinner

vstinner commented Oct 8, 2025

Copy link
Copy Markdown
Member

Merged, thank you for the fix.

vstinner pushed a commit that referenced this pull request Oct 8, 2025
@miss-islington @StanFromIreland
[3.13] gh-139805: Bump test_repl_eio timeout for slow builtbots (GH…
8234841 
…-139807) (#139813)

gh-139805: Bump `test_repl_eio` timeout for slow builtbots (GH-139807)
(cherry picked from commit e7e3d1d)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
vstinner pushed a commit that referenced this pull request Oct 8, 2025
@miss-islington @StanFromIreland
[3.14] gh-139805: Bump test_repl_eio timeout for slow builtbots (GH…
56072f9 
…-139807) (#139812)

gh-139805: Bump `test_repl_eio` timeout for slow builtbots (GH-139807)
(cherry picked from commit e7e3d1d)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@StanFromIreland StanFromIreland deleted the long-timeout branch October 9, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@cmaloney cmaloney cmaloney approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland @vstinner @bedevere-bot @cmaloney