gh-142461: Move misplaced NEWS entries to an appropriate section by Aniketsy · Pull Request #143411 · python/cpython

Aniketsy · 2026-01-04T06:06:51Z

This includes changes in 3.10 and 3.11.

Issue: Misplaced NEWS entries #142461

StanFromIreland · 2026-01-04T09:55:55Z

Update your branch to fix the CI.

picnixz · 2026-01-04T10:14:46Z

There are wrong changes. Zip is a built-in for instance. The ast module is a core module IIRC.

picnixz

Core and Builtins also include built-in types (e.g., zip, int, map, etc), and their methods. I won't go through all occurrences, but please correct them.

picnixz · 2026-01-04T10:24:48Z

Sign in to view

 .. date: 2021-05-04-21-55-49
 .. nonce: M9m8Qd
-.. section: Core and Builtins
+.. section: Library


This must stay as a core and builtins. It's about getattr/hasattr which are builtins.

bedevere-app · 2026-01-04T10:26:06Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Aniketsy · 2026-01-04T10:33:57Z

Thanks, I’ll revisit these and also correct them in the previous PR

picnixz · 2026-01-04T10:58:03Z

Sign in to view

-.. section: Core and Builtins
+.. section: Library

 Add ``sys._current_exceptions()`` function to retrieve a dictionary mapping


sysmodule is a core & built-in strictly speaking, but I think it's fine to keep it under Library as it's the user-facing stuff.

picnixz · 2026-01-04T10:58:28Z

 .. date: 2021-01-13-14-06-01
 .. nonce: _WS1Ok
-.. section: Core and Builtins
+.. section: Library


bytearray is a built-in...

picnixz · 2026-01-04T10:58:52Z

 .. date: 2018-12-20-23-59-23
 .. nonce: idHEcj
-.. section: Core and Builtins
+.. section: Library


This is affecting string formattin... so built-in.

picnixz · 2026-01-04T10:59:48Z

 .. date: 2021-03-16-17-12-54
 .. nonce: zAo6Ws
-.. section: Core and Builtins
+.. section: Library


picnixz · 2026-01-04T11:00:37Z

 .. date: 2021-09-02-01-28-01
 .. nonce: QDjM_l
-.. section: Core and Builtins
+.. section: Library


I'd say both Library and Core and Builtins. I'd prefer Core and Builtins because of open.

picnixz · 2026-01-04T11:01:18Z

 .. date: 2022-01-25-19-34-55
 .. nonce: mQLNPk
-.. section: Core and Builtins
+.. section: Library


Aniketsy · 2026-01-04T11:04:15Z

I’d like to apologize for increasing the review workload.

picnixz · 2026-01-04T13:15:37Z

 .. date: 2020-10-10-14-16-03
 .. nonce: Xop8sV
-.. section: Core and Builtins
+.. section: Library


This is still a core & builtins.

picnixz · 2026-01-04T13:16:18Z

-.. section: Core and Builtins
+.. section: Library

 Raise ImportWarning when calling find_loader().


Is this change affecting more only importlib or is it affecting the entire interpreter?

This change only affects importlib

I'm thinking this one is Core and Builtins. It's true that the changes are in importlib, but the PR modifies _bootstrap_external.py and thus affects how cpython finds modules globally. Specifically, I expect anything that uses find_loader() would be implicated by this change.

Thanks for pointing this out.

picnixz · 2026-01-04T13:17:42Z

 .. date: 2021-12-11-11-36-48
 .. nonce: sfThay
-.. section: Core and Builtins
+.. section: Library


This one is also a build. I said on the issue that one should be careful about possible duplicated NEWS entries because of backports.

serhiy-storchaka

Thank you for your PR @Aniketsy, great work. Mostly LGTM, I only left few minor comments.

serhiy-storchaka · 2026-01-09T09:36:01Z

@@ -643,7 +643,7 @@ Convert :mod:`!_bz2` to use :c:func:`PyType_FromSpec`.
 .. bpo: 41006
 .. date: 2020-06-18-00-07-09
 .. nonce: H-wN-d
-.. section: Core and Builtins
+.. section: Library


I would leave this as Core and Builtins. It is about the behavior of the core interpreter.

serhiy-storchaka · 2026-01-09T09:54:19Z

+.. section: Library

 Port the ``_warnings`` extension module to the multi-phase initialization


This is on border. I have no strong opinion.

There is a stable C API for warnings, but it can be used without importing the module, and I think this change did not affect the users of this C API. So, I think it is fine to keep Library.

serhiy-storchaka · 2026-01-09T10:06:42Z

@@ -917,7 +917,7 @@ Add ``__parameters__`` attribute and ``__getitem__`` operator to
 .. bpo: 44523
 .. date: 2021-06-29-11-49-29
 .. nonce: 67-ZIP
-.. section: Core and Builtins
+.. section: Library

 Remove the pass-through for :func:`hash` of :class:`weakref.proxy` objects
 to prevent unintended consequences when the original referred object dies


There is a C API for weakref.proxy, it is always present. I think it is closer to core.

serhiy-storchaka · 2026-01-09T10:21:54Z

@@ -434,7 +434,7 @@ cache when applicable.
 .. bpo: 46962
 .. date: 2022-03-08-21-59-57
 .. nonce: UomDfz
-.. section: Core and Builtins
+.. section: Library


types.GenericAlias and types.UnionType are builtins. It is okay to keep Core and Builtins.

Or you can split the entry on two. There was already other entry for documentation changes. https://github.com/python/cpython/pull/31769/changes

serhiy-storchaka · 2026-01-09T10:23:20Z

@@ -519,7 +519,7 @@ less or equal than the starting position of non-encodable characters.
 .. bpo: 34093
 .. date: 2018-07-14-16-58-00
 .. nonce: WaVD-f
-.. section: Core and Builtins
+.. section: Library


Marshalling is the part of the core.

And the purpose of this change to make .pyc files more stable.

serhiy-storchaka · 2026-01-09T10:30:21Z

@@ -102,7 +102,7 @@ blocks
 .. bpo: 42639
 .. date: 2020-12-09-01-55-10
 .. nonce: 5pI5HG
-.. section: Core and Builtins
+.. section: Library

 Make the :mod:`atexit` module state per-interpreter. It is now safe have
 more than one :mod:`atexit` module instance. Patch by Donghee Na and Victor


There is no stable public C API for atexit. Even if this is tied to interpreter internals, the only way it can be used by importing the atexit module. So, Library.

Aniketsy · 2026-01-09T14:54:05Z

@serhiy-storchaka Thanks for the review. I’ve applied the changes based on your suggestions.

serhiy-storchaka

LGTM. 👍

StanFromIreland · 2026-01-09T17:04:47Z

You need to update your branch to fix the CI.

serhiy-storchaka · 2026-01-12T16:23:42Z

@picnixz, have your comments been addressed?

picnixz · 2026-01-12T18:02:40Z

Yes they were. Thank you!

miss-islington-app · 2026-01-12T18:14:21Z

Thanks @Aniketsy for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app · 2026-01-12T18:14:22Z

Thanks @Aniketsy for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

pythonGH-143411) (cherry picked from commit 3d44f0a) Co-authored-by: Aniket <148300120+Aniketsy@users.noreply.github.com>

bedevere-app · 2026-01-12T18:14:35Z

GH-143745 is a backport of this pull request to the 3.13 branch.

bedevere-app · 2026-01-12T18:14:40Z

GH-143746 is a backport of this pull request to the 3.14 branch.

…on (GH-143411) (GH-143746) (cherry picked from commit 3d44f0a) Co-authored-by: Aniket <148300120+Aniketsy@users.noreply.github.com>

…on (GH-143411) (GH-143745) (cherry picked from commit 3d44f0a) Co-authored-by: Aniket <148300120+Aniketsy@users.noreply.github.com>

pythonGH-143411)

Move misplaced NEWS entries to an appropriate section

ee9bb16

bedevere-app Bot mentioned this pull request Jan 4, 2026

Misplaced NEWS entries #142461

Closed

bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Jan 4, 2026

github-project-automation Bot added this to Docs PRs Jan 4, 2026

github-project-automation Bot moved this to Todo in Docs PRs Jan 4, 2026

picnixz requested changes Jan 4, 2026

View reviewed changes

bedevere-app Bot added awaiting changes and removed awaiting review labels Jan 4, 2026

Move misplaced NEWS entries to an appropriate section

f19e5e6

Aniketsy force-pushed the fix-142461-clean branch from 975074a to f19e5e6 Compare January 4, 2026 10:56

picnixz reviewed Jan 4, 2026

View reviewed changes

Comment thread Misc/NEWS.d/3.10.0a7.rst

picnixz reviewed Jan 4, 2026

View reviewed changes

Comment thread Misc/NEWS.d/3.11.0b1.rst

Aniketsy added 2 commits January 4, 2026 16:57

Move misplaced NEWS entries to an appropriate section

5b061c6

Move misplaced NEWS entries to an appropriate section

64a270c

picnixz reviewed Jan 4, 2026

View reviewed changes

Move misplaced NEWS entries to an appropriate section

ce5603d

serhiy-storchaka self-requested a review January 9, 2026 09:33

serhiy-storchaka reviewed Jan 9, 2026

View reviewed changes

Move misplaced NEWS entries to an appropriate section

75282c2

serhiy-storchaka approved these changes Jan 9, 2026

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting changes labels Jan 9, 2026

Merge branch 'main' into fix-142461-clean

3402d1c

picnixz approved these changes Jan 12, 2026

View reviewed changes

serhiy-storchaka merged commit 3d44f0a into python:main Jan 12, 2026
28 checks passed

bedevere-app Bot removed the awaiting merge label Jan 12, 2026

github-project-automation Bot moved this from Todo to Done in Docs PRs Jan 12, 2026

serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 12, 2026

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jan 12, 2026

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jan 12, 2026

reidenong pushed a commit to reidenong/cpython that referenced this pull request Jan 12, 2026

pythongh-142461: Move misplaced NEWS entries to an appropriate section (

7f9b1eb

pythonGH-143411)

thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026

pythongh-142461: Move misplaced NEWS entries to an appropriate section (

15a37ba

pythonGH-143411)

		.. section: Library

		Port the ``_warnings`` extension module to the multi-phase initialization

Uh oh!

Uh oh!

Conversation

Aniketsy commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StanFromIreland commented Jan 4, 2026

Uh oh!

picnixz commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

picnixz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

bedevere-app Bot commented Jan 4, 2026

Uh oh!

Aniketsy commented Jan 4, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Aniketsy commented Jan 4, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Aniketsy commented Jan 9, 2026

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

StanFromIreland commented Jan 9, 2026

Uh oh!

serhiy-storchaka commented Jan 12, 2026

Uh oh!

picnixz commented Jan 12, 2026

Uh oh!

Uh oh!

Aniketsy commented Jan 4, 2026 •

edited

Loading

picnixz commented Jan 4, 2026 •

edited

Loading

picnixz left a comment •

edited

Loading