Skip to content

gh-146343: Add text MIME types in mimetypes.py#146344

Open
clin1234 wants to merge 15 commits into
python:mainfrom
clin1234:patch-5
Open

gh-146343: Add text MIME types in mimetypes.py#146344
clin1234 wants to merge 15 commits into
python:mainfrom
clin1234:patch-5

Conversation

@clin1234

@clin1234 clin1234 commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

- ``.gml`` for ``text/vnd.gml``
- ``.gv`` for ``text/vnd.graphviz``
- ``.wgsl`` for ``text/wgsl``
- ``.ent`` for ``text/xml-external-parsed-entity``

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add your name here as well

@benediktjohannes benediktjohannes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing the 3.15 rst release notes update (maybe this can be combined with the others as well). Apart from that, LGTM from a short overview! Thanks for doing this!

@benediktjohannes

Copy link
Copy Markdown
Contributor

Please also have a look on the check failures, whether they are related

@clin1234

clin1234 commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

Will this be merged in before beta1, and can this still be merged in during the beta releases?

@hugovk

hugovk commented May 4, 2026

Copy link
Copy Markdown
Member

Will this be merged in before beta1,

I'm not sure if I'll have time to review them all, it's a big list. Are there any you actually need? Or is it it more of trying to be complete?

and can this still be merged in during the beta releases?

No, only bug fixes and docs changes during beta.

@clin1234 clin1234 force-pushed the patch-5 branch 2 times, most recently from f4bee25 to c56cbd1 Compare May 4, 2026 15:31
@read-the-docs-community

read-the-docs-community Bot commented May 4, 2026

Copy link
Copy Markdown

@clin1234

clin1234 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

@benediktjohannes @hugovk, mind reviewing this PR again?

@hugovk

hugovk commented Jul 7, 2026

Copy link
Copy Markdown
Member

Please see my question: #146344 (comment).

@hugovk

hugovk commented Jul 7, 2026

Copy link
Copy Markdown
Member

For next time, please don't force push PRs. We squash merge at the end, and it's easier to review without force pushes.

https://devguide.python.org/getting-started/pull-request-lifecycle/#don-t-force-push

@clin1234

Copy link
Copy Markdown
Contributor Author

@hugovk, when CI passes, can you review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants