gh-143955: Prevent schema drift false-positives in asyncio tools tests#148525
Merged
pablogsal merged 1 commit intoApr 14, 2026
Merged
Conversation
Replace namedtuple reimplementations with factory helpers that wrap the real _remote_debugging structseq types. This prevents silent drift between test stubs and production structs, as previously occurred in pythongh-142394/pythongh-143952.
johnslavik
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
April 13, 2026 21:00
Member
Author
|
I don't expect a schema change in 3.14 so let's not backport it |
johnslavik
changed the title
_remote_debugging structs directly in test_tools
pablogsal
approved these changes
Apr 14, 2026
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace namedtuple reimplementations with factory helpers that wrap the real _remote_debugging structseq types. This prevents silent drift between test stubs and production structs, as previously occurred in gh-142394 (see gh-143952).
_remote_debuggingdirectly #143955