Skip to content

Add full stop for a calendar.rst sentence#148756

Merged
ZeroIntensity merged 2 commits into
mainfrom
unknown repository
Apr 20, 2026
Merged

Add full stop for a calendar.rst sentence#148756
ZeroIntensity merged 2 commits into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Apr 19, 2026

Copy link
Copy Markdown

A full stop is missing for the sentence

Set the first weekday to *firstweekday*, passed as an :class:`int` (0--6)

The above similar lines have full stops and for consistency this statement is corrected.


📚 Documentation preview 📚: https://cpython-previews--148756.org.readthedocs.build/

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if therr are other typos in this file and if so, correct them altogether? TiA

@ghost

ghost commented Apr 20, 2026

Copy link
Copy Markdown
Author

Can you check if therr are other typos in this file and if so, correct them altogether? TiA

I have fixed some typos,spacings and grammar inconsistencies.
I could also fix the term "day of the month" to "day-of-month" if you wish.

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. I think "day of the month" is fine; let's not change that.

@ZeroIntensity ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Apr 20, 2026
@ZeroIntensity ZeroIntensity enabled auto-merge (squash) April 20, 2026 14:32
@ZeroIntensity ZeroIntensity merged commit 983c746 into python:main Apr 20, 2026
34 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Apr 20, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @manoj-km24 for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 20, 2026
(cherry picked from commit 983c746)

Co-authored-by: Manoj K M <manojkmdev24@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 20, 2026
(cherry picked from commit 983c746)

Co-authored-by: Manoj K M <manojkmdev24@gmail.com>
@bedevere-app

bedevere-app Bot commented Apr 20, 2026

Copy link
Copy Markdown

GH-148795 is a backport of this pull request to the 3.14 branch.

@bedevere-app

bedevere-app Bot commented Apr 20, 2026

Copy link
Copy Markdown

GH-148796 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed needs backport to 3.14 bugs and security fixes needs backport to 3.13 bugs and security fixes labels Apr 20, 2026
ZeroIntensity pushed a commit that referenced this pull request Apr 20, 2026
Docs: Fix some typos in `calendar.rst` (GH-148756)
(cherry picked from commit 983c746)

Co-authored-by: Manoj K M <manojkmdev24@gmail.com>
ZeroIntensity pushed a commit that referenced this pull request Apr 20, 2026
Docs: Fix some typos in `calendar.rst` (GH-148756)
(cherry picked from commit 983c746)

Co-authored-by: Manoj K M <manojkmdev24@gmail.com>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants