Skip to content

bpo-37698: Update doc of PyBuffer_ToContiguous - #14992

Merged
miss-islington merged 2 commits into
python:masterfrom
shihai1991:bpo_37698
Sep 11, 2019
Merged

bpo-37698: Update doc of PyBuffer_ToContiguous#14992
miss-islington merged 2 commits into
python:masterfrom
shihai1991:bpo_37698

Conversation

@shihai1991

@shihai1991 shihai1991 commented Jul 28, 2019 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

@shihai1991
Update doc of PyBuffer_ToContiguous
7d95247 
order could be 'A' too in PyBuffer_ToContiguous()
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jul 28, 2019
mangrisano
mangrisano approved these changes Jul 30, 2019
View reviewed changes

@mangrisano mangrisano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for opening this PR.

@shihai1991

shihai1991 commented Jul 30, 2019

Copy link
Copy Markdown
Member Author

LGTM. Thank you for opening this PR.

thanks for review :)

@shihai1991

shihai1991 commented Aug 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

cc @pitrou @vstinner

matrixise
matrixise requested changes Sep 11, 2019
View reviewed changes

@matrixise matrixise left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, but could you read my comment and just update your PR?

Thank you

Comment thread Doc/c-api/buffer.rst Outdated
@bedevere-bot

bedevere-bot commented Sep 11, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@shihai1991

shihai1991 commented Sep 11, 2019

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Sep 11, 2019

Copy link
Copy Markdown

Thanks for making the requested changes!

@matrixise: please review the changes made to this pull request.

@miss-islington
miss-islington merged commit 15f5a75 into python:master Sep 11, 2019
@miss-islington

miss-islington commented Sep 11, 2019

Copy link
Copy Markdown
Contributor

Thanks @shihai1991 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

miss-islington commented Sep 11, 2019

Copy link
Copy Markdown
Contributor

Sorry @shihai1991, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 15f5a7527b87e11fcf23069c147fd4cb7d42cfb0 3.8

@miss-islington miss-islington self-assigned this Sep 11, 2019
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@shihai1991 @miss-islington
bpo-37698: Update doc of PyBuffer_ToContiguous (pythonGH-14992)
d55a721 
https://bugs.python.org/issue37698
(cherry picked from commit 15f5a75)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
@bedevere-bot

bedevere-bot commented Sep 11, 2019

Copy link
Copy Markdown

GH-15998 is a backport of this pull request to the 3.7 branch.

@bedevere-bot

bedevere-bot commented Sep 11, 2019

Copy link
Copy Markdown

GH-15999 is a backport of this pull request to the 3.8 branch.

matrixise pushed a commit to matrixise/cpython that referenced this pull request Sep 11, 2019
@shihai1991 @matrixise
[3.8] bpo-37698: Update doc of PyBuffer_ToContiguous (pythonGH-14992)
b9a3300 
https://bugs.python.org/issue37698
(cherry picked from commit 15f5a75)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
matrixise pushed a commit that referenced this pull request Sep 11, 2019
@miss-islington @shihai1991 @matrixise
bpo-37698: Update doc of PyBuffer_ToContiguous (GH-14992) (GH-15998)
c62da14 
https://bugs.python.org/issue37698
(cherry picked from commit 15f5a75)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
matrixise added a commit that referenced this pull request Sep 11, 2019
@matrixise @shihai1991
[3.8] bpo-37698: Update doc of PyBuffer_ToContiguous (GH-14992) (GH-1…
965e53a 
…5999)

https://bugs.python.org/issue37698
(cherry picked from commit 15f5a75)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
@matrixise

matrixise commented Sep 11, 2019

Copy link
Copy Markdown
Member

Hi @shihai1991

Thank you for your PR, I have merged it into master, 3.8 and 3.7.

Have a nice day,

DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@shihai1991 @DinoV
bpo-37698: Update doc of PyBuffer_ToContiguous (pythonGH-14992)
d919528 
https://bugs.python.org/issue37698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matrixise matrixise matrixise approved these changes
+1 more reviewer
@mangrisano mangrisano mangrisano approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@miss-islington miss-islington

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@shihai1991 @bedevere-bot @miss-islington @matrixise @mangrisano @the-knights-who-say-ni