gh-148932: Fix profiling.sampling on Windows virtual environments#150541
Open
edvilme wants to merge 7 commits into
Open
gh-148932: Fix profiling.sampling on Windows virtual environments#150541edvilme wants to merge 7 commits into
profiling.sampling on Windows virtual environments#150541edvilme wants to merge 7 commits into
Conversation
Documentation build overview
98 files changed ·
|
chris-eibl
approved these changes
Jun 4, 2026
Member
chris-eibl
left a comment
There was a problem hiding this comment.
I've just verified locally that it works in a virtual environment now, so approving.
Thanks for your contribution @edvilme!
I'd even backport to 3.15 (rather a bug fix than a feature IMO), but leave the final decision to @pablogsal.
Contributor
Author
|
Hi @chris-eibl thank you!! |
Member
|
No, thanks. Let's wait for Pablo's decision first, and then most probably |
pablogsal
reviewed
Jun 4, 2026
pablogsal
approved these changes
Jun 5, 2026
Member
|
Please address that nit and ping me again so I or @chris-eibl can land |
Contributor
Author
|
Renamed method to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it is not possible to run
profiling.samplingfrom a Windows venv because virtual environments use shims to launch the original interpreter, but the shim itself isn't a real Python process.Fix
Added
_resolve_venv_childfunction to detect when the profiler is started from a virtual environment process on Windows, and automatically redirect it to the real child Python process. This prevents profiling against the shim instead of the actual Python process.The
SampleProfilerclass uses the resolved child PID when initializing.Before
After
CC @pablogsal