gh-151029: Fix sys.remote_exec() unable to find writable memory when libpython replaced on disk#151032
Merged
Merged
Conversation
Co-authored-by: Pablo Galindo <pablogsal@gmail.com>
…er libpython removal
pablogsal
approved these changes
Jun 27, 2026
pablogsal
left a comment
Member
There was a problem hiding this comment.
LGTM. I reiewed it a couple of times and couldn't find anything. Tested also locally. I pushed a small follow-up that factors the duplicated deleted-mapping remote-exec test flow into a shared helper.
|
Thanks @ambv for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
Sorry, @ambv and @pablogsal, I could not cleanly backport this to |
|
GH-152443 is a backport of this pull request to the 3.15 branch. |
|
GH-152464 is a backport of this pull request to the 3.14 branch. |
pablogsal
pushed a commit
that referenced
this pull request
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case where
/proc/<pid>/mapspoints at a libpython that got deleted from disk or replaced with a new file,sys.remote_exec()used to fail to find the remote memory address to write the debug script path to.This change makes it able to recover and read this information from the remote process' memory. See issue for rationale and details.