bpo-37785: argparse uses %s in gettext calls causing xgettext warnings#15161
Merged
Conversation
CuriousLearner
requested changes
Aug 9, 2019
CuriousLearner
left a comment
CuriousLearner
left a comment
Member
There was a problem hiding this comment.
Just one minor comment.
Overall looks good.
Co-Authored-By: Sanyam Khurana <8039608+CuriousLearner@users.noreply.github.com>
CuriousLearner
approved these changes
Aug 12, 2019
CuriousLearner
left a comment
CuriousLearner
left a comment
Member
There was a problem hiding this comment.
Just modify the NEWS entry. Overall looks good!
Co-Authored-By: Sanyam Khurana <8039608+CuriousLearner@users.noreply.github.com>
Contributor
Author
Thanks! |
Contributor
|
Thanks @kulikjak for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
GH-16080 is a backport of this pull request to the 3.8 branch. |
|
GH-16081 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 13, 2019
(cherry picked from commit 42671ae) Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Sep 13, 2019
miss-islington
added a commit
that referenced
this pull request
Sep 13, 2019
JulienPalard
added a commit
that referenced
this pull request
Sep 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running xgettext on argparse.py (of any currently supported Python 3.x) return following warning:
./Lib/argparse.py: warning: 'msgid' format string with unnamed arguments cannot be properly localized: The translator cannot reorder the arguments. Please consider using a format string with named arguments, and a mapping instead of a tuple for the arguments.
https://bugs.python.org/issue37785