gh-151776: Fix test_state_getters on terminals without insert/delete capability#152304
Merged
serhiy-storchaka merged 1 commit intoJun 26, 2026
Merged
Conversation
…elete capability idcok() and idlok() take effect only when the terminal can insert or delete characters or lines, so check their getters against the terminal's capabilities instead of asserting an unconditional round-trip. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
idcok()andidlok()only take effect when the terminal can insert or delete characters or lines (ncurses sets the window flag toflag && has_ic()andflag && (has_il() || change_scroll_region)respectively). On terminals without those capabilities,is_idcok()/is_idlok()returnFalseeven after setting the flag toTrue, sotest_state_gettersfailed on many buildbots.Drop these two from the unconditional round-trip loop and assert their getters against the terminal's actual capabilities instead.