gh-152260: Fix flaky curses test_scr_dump on macOS#152390
Merged
serhiy-storchaka merged 1 commit intoJun 27, 2026
Merged
Conversation
The screen dump embeds raw pointers that change after scr_restore(), so comparing dump bytes is unreliable. Test the round-trip functionally instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The screen dump embeds raw pointers that change after
scr_restore()reallocates the virtual-screen structures, so comparing dump bytes is
unreliable on platforms such as macOS.
The previous attempt (gh-152260, PR #152340) tried to detect this by
comparing two consecutive dumps of the unchanged screen and only
byte-comparing when they matched. That probe is a false predictor: two
back-to-back dumps share the same live-allocation pointers, but the
asserted comparison is against a dump taken after
scr_restore(), whosepointers differ. So
test_scr_dumpstayed flaky-red onmacos-26-intel.Drop the byte comparison entirely and exercise the
scr_dump/scr_restore/scr_init/scr_setround-trip functionally.