Use tkinter wrapper methods instead of raw Tcl calls in turtle and IDLE

[serhiy-storchaka]

Replace explicit tk.call() invocations in turtle and idlelib with the equivalent higher-level tkinter wrapper methods. No behavior change.

• turtle: rootwindow.wm_attributes(topmost=...) instead of call('wm', 'attributes', '.', '-topmost', ...), using the keyword form of wm_attributes() (added in wm_attributes doesn't take keyword arguments #43457).
• idlelib.macosx._init_tk_type(): root.winfo_server() instead of root.tk.call('winfo', 'server', '.').
• idlelib tests: after_info() instead of tk.call('after', 'info').

[terryjreedy]

I was thinking about asking you if any of the tk calls could be updated. Are the 2 new root.x wrapper methods in IDLE in main only or at least in 3.15, so an IDLE backport can be done?

Either way, I think that merging this now and dealing with a possible but very unlikely future backport merge conflict is better than waiting a couple of years until these changes can be backported completely.

There are about 20 'after' 'info' calls in tests that can be replaced by after_info and backported to 3.13. I will do these separately. Did you check whether any of the other ~20 other calls replaced here now have wrappers?

[serhiy-storchaka]

tk_scaling is 3.15, wm_attributes -- 3.13, winfo_server -- always. after_info -- 3.13. I can add after_info here.

[terryjreedy]

Emscripten build and test failed. The [Explain error] AI 'failed', with no explanation. Since the AI apparently replaced the ability to manually scan the test log, I just reran.

[terryjreedy]

I presume you made changes with Opus. Can it undo 3.x changes for backport to 3.x?? For each file in the diff, [...] on the right expands to view, edit, or delete file, but not revert file.

[serhiy-storchaka]

Split out to #152465. I force-pushed to create a single simple commit message.

[terryjreedy]

Do you want me to merge and tend to backports, or are you still thinking about these 2 PRs?

[serhiy-storchaka]

I only wait for your approve, because it is just cosmetic change.

[terryjreedy]

In the winfo server and wm attributes replacements, I don't know what the original '.' arg was, but assume you do and correctly omitted it in the the replacement.

I otherwise approve of the IDLE changes and would like them backported. I don't care about the turtle change either way.

[miss-islington-app]

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

[miss-islington-app]

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

[miss-islington-app]

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fc866dc84ec430ab22d60609520f7ab27267baef 3.14

[miss-islington-app]

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fc866dc84ec430ab22d60609520f7ab27267baef 3.13

[miss-islington-app]

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

[bedevere-app]

GH-152648 is a backport of this pull request to the 3.15 branch.

[serhiy-storchaka]

In the winfo server and wm attributes replacements, I don't know what the original '.' arg was

It was the path to the toplevel widget (the root in that case). In methods it is inferred from self.

[bedevere-app]

GH-152662 is a backport of this pull request to the 3.14 branch.

[bedevere-app]

GH-152663 is a backport of this pull request to the 3.13 branch.

[terryjreedy]

Backports merged, thank you.