Skip to content

gh-153205: Set MemoryError in stackref array conversion#153206

Merged
sobolevn merged 4 commits into
python:mainfrom
aisk:fix-stackref-array-nomemory
Jul 7, 2026
Merged

gh-153205: Set MemoryError in stackref array conversion#153206
sobolevn merged 4 commits into
python:mainfrom
aisk:fix-stackref-array-nomemory

Conversation

@aisk

@aisk aisk commented Jul 6, 2026

Copy link
Copy Markdown
Member

@aisk

aisk commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

This change is in _PyObjectArray_FromStackRefArray, which is added in 3.14, so we only need to backport it to 3.14 / 3.15.

@aisk aisk added needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 6, 2026
@Fidget-Spinner

Copy link
Copy Markdown
Member

Fix looks right. However, I think this needs a news entry as it's fixing a user-visible bug for low memory situations?

@aisk aisk removed the skip news label Jul 7, 2026
Comment thread Misc/NEWS.d/next/Core_and_Builtins/2026-07-07-04-16-48.gh-issue-153205.5fE8QZ.rst Outdated
aisk and others added 2 commits July 7, 2026 21:45

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Currently there's a problem in CI with san job, see #153201

Please, ping me once again once it will be fixed, so I can merge the PR :)

@sobolevn sobolevn enabled auto-merge (squash) July 7, 2026 13:57
@sobolevn sobolevn merged commit 08759ff into python:main Jul 7, 2026
195 of 201 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @aisk for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-app

bedevere-app Bot commented Jul 7, 2026

Copy link
Copy Markdown

GH-153272 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 7, 2026
@bedevere-app

bedevere-app Bot commented Jul 7, 2026

Copy link
Copy Markdown

GH-153273 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 7, 2026
@aisk aisk deleted the fix-stackref-array-nomemory branch July 7, 2026 16:09
sobolevn added a commit that referenced this pull request Jul 7, 2026
…153206) (#153273)

gh-153205: Set `MemoryError` in stackref array conversion (GH-153206)
(cherry picked from commit 08759ff)

Co-authored-by: An Long <aisk@users.noreply.github.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Jul 7, 2026
…153206) (#153272)

gh-153205: Set `MemoryError` in stackref array conversion (GH-153206)
(cherry picked from commit 08759ff)

Co-authored-by: An Long <aisk@users.noreply.github.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants