Skip to content

gh-143990: Do not assume the requested font size in test_font #153322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 1 commit into from
Jul 8, 2026
+8 −4
Merged

gh-143990: Do not assume the requested font size in test_font #153322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions Lib/test/test_tkinter/test_font.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ def setUpClass(cls):
except tkinter.TclError:
cls.font = font.Font(root=cls.root, name=fontname, exists=False)

def actual_size(self, desc):
# The requested size is not always available (e.g. bitmap fonts).
return self.root.tk.call('font', 'actual', desc, '-size')

def test_configure(self):
self.assertEqual(self.font.config, self.font.configure)
options = self.font.configure()
Expand Down Expand Up @@ -51,7 +55,7 @@ def test_create(self):
f = font.Font(root=self.root, font=('Times', 20, 'bold'))
self.assertIn(f.name, font.names(self.root))
self.assertEqual(f.actual('weight'), 'bold')
self.assertEqual(f.cget('size'), sizetype(20))
self.assertEqual(f.cget('size'), self.actual_size(('Times', 20, 'bold')))

# ... or from the keyword options.
f = font.Font(root=self.root, family='Times', size=20, weight='bold')
Expand All @@ -62,13 +66,13 @@ def test_create(self):
# Explicit options override the corresponding settings of *font*.
f = font.Font(root=self.root, font=('Times', 20, 'bold'), weight='normal')
self.assertEqual(f.actual('weight'), 'normal')
self.assertEqual(f.cget('size'), sizetype(20))
self.assertEqual(f.cget('size'), self.actual_size(('Times', 20, 'bold')))

# The new font can be given an explicit name.
f = font.Font(root=self.root, name='testfont', font=('Times', 20))
self.assertEqual(f.name, 'testfont')
self.assertIn('testfont', font.names(self.root))
self.assertEqual(f.cget('size'), sizetype(20))
self.assertEqual(f.cget('size'), self.actual_size(('Times', 20)))
# Reusing the name of an existing font fails.
self.assertRaises(tkinter.TclError, font.Font, root=self.root,
name='testfont', font=('Times', 10))
Expand Down Expand Up @@ -96,7 +100,7 @@ def test_existing(self):
self.assertEqual(str(f), 'Times 20 bold')
self.assertNotIn(f.name, font.names(self.root))
self.assertEqual(f.actual('weight'), 'bold')
self.assertEqual(f.actual('size'), sizetype(20))
self.assertEqual(f.actual('size'), self.actual_size(('Times', 20, 'bold')))
# It can be used as a widget option, with the same effect as the
# description itself (gh-143990).
self.assertEqual(tkinter.Label(self.root, font=f).cget('font'),
Expand Down
Loading