gh-153486: Preserve negative indices in compact int subscript specializations#153523
Draft
KRRT7 wants to merge 8 commits into
Draft
gh-153486: Preserve negative indices in compact int subscript specializations#153523KRRT7 wants to merge 8 commits into
KRRT7 wants to merge 8 commits into
Conversation
This reverts commit 7b711cc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up on
gh-153486.The base compact-int guard work tightened several specialized subscript paths to only stay specialized for non-negative compact integer indices. That kept the guards simple, but it also meant negative compact indices deoptimized even in cases where the specialized path could handle them correctly.
This PR restores negative-index handling in the specialized paths where it is valid and straightforward:
BINARY_OP_SUBSCR_LIST_INTBINARY_OP_SUBSCR_TUPLE_INTBINARY_OP_SUBSCR_STR_INTBINARY_OP_SUBSCR_USTR_INTSTORE_SUBSCR_LIST_INTIt does this by:
intindicesTests are included to cover the negative-index specialized cases.