gh-153537: Fix Element re-init memory leak in the C accelerator#153538
Open
tonghuaroot wants to merge 1 commit into
Open
gh-153537: Fix Element re-init memory leak in the C accelerator#153538tonghuaroot wants to merge 1 commit into
tonghuaroot wants to merge 1 commit into
Conversation
element_init allocated a new extra without releasing the previous one, leaking the element's children and attributes on a second __init__ call. Clear the old extra first, so re-init discards the previous children and attributes, matching the pure-Python implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Element.__init__in the C accelerator leaked the element's previous children and attributes when called more than once, becausecreate_extraallocated a newextrawithout freeing the old one. Clear it first, so re-initialization now discards the previous children and attributes like the pure-Python implementation.