gh-153603: Fix out-of-bounds read in the ISO-2022 decoder for an unknown charset#153604
Open
tonghuaroot wants to merge 1 commit into
Open
gh-153603: Fix out-of-bounds read in the ISO-2022 decoder for an unknown charset#153604tonghuaroot wants to merge 1 commit into
tonghuaroot wants to merge 1 commit into
Conversation
…n unknown charset The designation-table scan compiled its terminator only under Py_DEBUG, so a release build walked off the table for an unknown charset set via setstate(). Make the terminator unconditional and report the byte as undecodable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ISO-2022 decoders' designation-table scan compiled its
dsg->mark != '\0'terminator only under
Py_DEBUG, so a release build walked off the table for anunknown charset set via
setstate(). Make the terminator unconditional andreport the byte as undecodable when the charset is unknown.