gh-153658: Fix sqlite3 iterdump() for table names containing a single quote#153659
Open
tonghuaroot wants to merge 2 commits into
Open
gh-153658: Fix sqlite3 iterdump() for table names containing a single quote#153659tonghuaroot wants to merge 2 commits into
tonghuaroot wants to merge 2 commits into
Conversation
…single quote Patch by tonghuaroot.
erlend-aasland
added
needs backport to 3.13
erlend-aasland
left a comment
erlend-aasland
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the report and the PR! Mostly looks good, but I have a nitpick regarding the inlined escaping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlite3.Connection.iterdump()raisedsqlite3.OperationalErrorfor a tableor column name containing a single quote, because the generated INSERT
statement embeds the quoted identifier inside a single-quoted SQL string
literal without doubling the single quotes. The
FROMclause uses theidentifier form as-is; only the string-literal copy needs escaping.
Doubling the single quotes in the string-literal copy makes the dump of a
table whose name contains
'well-formed again, and it round-trips throughexecutescript(). Names containing a double quote or a newline were alreadyhandled and are unaffected.