[3.13] gh-153631: Ensure iOS simulator is running before starting build (GH-153632)#153675
Open
freakboy3742 wants to merge 1 commit into
Open
[3.13] gh-153631: Ensure iOS simulator is running before starting build (GH-153632)#153675freakboy3742 wants to merge 1 commit into
freakboy3742 wants to merge 1 commit into
Conversation
…ng build (pythonGH-153632) Makes a small change to the iOS build script to improve build stability. xcodebuild doesn't guarantee that the CoreSimulatorService is running before starting a simulator. If the service isn't running, xcodebuild reports that no simulators are available, and fails to start the test app. However, simctl blocks until the simulator is available, and simctl is used to evaluate the default simulator. So - the iOS build script now unconditionally determines the default simulator, even if a specific simulator is requested. (cherry picked from commit 2dc1a91) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
This was referenced Jul 13, 2026
Contributor
Author
|
Note for review purposes: The 3.13 branch doesn't have a GitHub Actions CI config, and the buildbot will fail on PR builds because there's no way to identify the base branch of a PR. The Buildbot will run once the PR is merged to the 3.13 branch, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes a small change to the iOS build script to improve build stability. xcodebuild doesn't guarantee that the CoreSimulatorService is running before starting a simulator. If the service isn't running, xcodebuild reports that no simulators are available, and fails to start the test app. However, simctl blocks until the simulator is available, and simctl is used to evaluate the default simulator. So - the iOS build script now unconditionally determines the default simulator, even if a specific simulator is requested.
(cherry picked from commit 2dc1a91)