Skip to content

gh-153689: Fix integer overflows in PyObject_CopyData #153690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imabd645 wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −2
Open

gh-153689: Fix integer overflows in PyObject_CopyData #153690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/C_API/2026-07-14-12-54-20.gh-issue-153689.abcdef.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix potential integer overflows in PyObject_CopyData when processing multi-dimensional buffers with exceptionally large dimensions or shapes.
15 changes: 13 additions & 2 deletions Objects/abstract.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,12 @@ int PyObject_CopyData(PyObject *dest, PyObject *src)

/* Otherwise a more elaborate copy scheme is needed */

/* XXX(nnorwitz): need to check for overflow! */
if ((size_t)view_src.ndim > (size_t)PyBUF_MAX_NDIM) {
PyErr_SetString(PyExc_BufferError, "invalid ndim");
PyBuffer_Release(&view_dest);
PyBuffer_Release(&view_src);
return -1;
}
indices = (Py_ssize_t *)PyMem_Malloc(sizeof(Py_ssize_t)*view_src.ndim);
if (indices == NULL) {
PyErr_NoMemory();
Expand All @@ -731,7 +736,13 @@ int PyObject_CopyData(PyObject *dest, PyObject *src)
}
elements = 1;
for (k=0; k<view_src.ndim; k++) {
/* XXX(nnorwitz): can this overflow? */
if (view_src.shape[k] != 0 && elements > PY_SSIZE_T_MAX / view_src.shape[k]) {
PyMem_Free(indices);
PyBuffer_Release(&view_dest);
PyBuffer_Release(&view_src);
PyErr_SetString(PyExc_BufferError, "buffer is too large");
return -1;
}
elements *= view_src.shape[k];
}
while (elements--) {
Expand Down
Loading