gh-153692: Raise wave.Error for a truncated fmt chunk in wave.open#153693
Open
tonghuaroot wants to merge 2 commits into
Open
gh-153692: Raise wave.Error for a truncated fmt chunk in wave.open#153693tonghuaroot wants to merge 2 commits into
tonghuaroot wants to merge 2 commits into
Conversation
wave.open(f, 'rb') is documented to raise wave.Error for a file that violates the WAV format, but Wave_read.initfp() let the EOFError raised by _read_fmt_chunk() on a truncated fmt chunk escape raw. Wrap that call so a truncated fmt chunk raises wave.Error, matching every other malformed-input path in the module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wave.open(f, 'rb')is documented to raisewave.Errorfor a file thatviolates the WAV format, but
Wave_read.initfp()let theEOFErrorraised by_read_fmt_chunk()on a truncatedfmtchunk escape raw. Wrap that call so atruncated fmt chunk raises
wave.Error, matching every other malformed-inputpath in the module.