gh-153313: Work around string decoding bug in emcc 6.0.2#153698
Merged
Conversation
hoodmane
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland and
itamaro
as code owners
hoodmane
changed the title
corona10
approved these changes
Jul 14, 2026
corona10
left a comment
corona10
left a comment
Member
There was a problem hiding this comment.
lgtm with cross-checking the solution from emscripten-core/emscripten#27241 (comment)
Contributor
Author
|
I guess it would have been good to run the build bot on this one. But it worked locally so probably it's a correct fix in the build bot too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #153313. Can remove once we update to emcc 6.0.3. Upstream issue:
emscripten-core/emscripten#27241