gh-152433: Windows: modernize and refactor fileutils to allow build for Windows UWP#153700
Open
thexai wants to merge 1 commit into
Open
gh-152433: Windows: modernize and refactor fileutils to allow build for Windows UWP#153700thexai wants to merge 1 commit into
thexai wants to merge 1 commit into
Conversation
…uild for Windows UWP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows: modernize and refactor fileutils to allow build for Windows UWP
This is probably the last relevant commit missing to allow compile all Python core for UWP.
GetFileInformationByHandleis not supported in UWP, then is replaced with more modernGetFileInformationByHandleExcalls.Also code refactored to avoid some duplicated code.
Note that Xbox (all models) runs only on Windows 11 based OS. Then is guaranteed that "fast stat" code (based on
GetFileInformationByName) is supported:cpython/Modules/posixmodule.c
Line 2299 in 050a84b
"slow stat" code path is not much relevant for UWP but also works if replaced
CreateFileWwithCreateFile2(in other PR).