gh-152075: Avoid lock contention in _Py_Specialize_LoadGlobal under free threading#153720
Open
hawkinsp wants to merge 1 commit into
Open
gh-152075: Avoid lock contention in _Py_Specialize_LoadGlobal under free threading#153720hawkinsp wants to merge 1 commit into
hawkinsp wants to merge 1 commit into
Conversation
…nder free threading Under high thread concurrency in free-threaded builds, `_Py_Specialize_LoadGlobal`suffers from lock contention when acquiring the critical section mutexes for the `globals` and `builtins` dictionaries during bytecode specialization. This PR introduces non-blocking critical section entry (`PyCriticalSection2_TryBegin`) and updates LOAD_GLOBAL bytecode specialization to attempt a non-blocking lock acquisition. If acquiring the two object mutexes would block, specialization is skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under high thread concurrency in free-threaded builds,
_Py_Specialize_LoadGlobalsuffers from lock contention when acquiring the critical section mutexes for theglobalsandbuiltinsdictionaries during bytecode specialization.This PR introduces non-blocking critical section entry (
PyCriticalSection2_TryBegin) and updates LOAD_GLOBAL bytecode specialization to attempt a non-blocking lock acquisition. If acquiring the two object mutexes would block, specialization is skipped.