gh-154675: Use lazy imports in the top-level modules of importlib#154657
Open
brettcannon wants to merge 1 commit into
Open
gh-154675: Use lazy imports in the top-level modules of importlib#154657brettcannon wants to merge 1 commit into
brettcannon wants to merge 1 commit into
Conversation
brettcannon
requested review from
FFY00,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
July 24, 2026 22:59
Member
|
No objection to tidying the imports here, but I don't see much if any time saved here: We could get some good savings from |
|
|
||
| import sys | ||
| import types | ||
|
|
Member
There was a problem hiding this comment.
Do we separate them from regular imports, or group them together? In dataclasses, inspect, http.cookies and ast we have them together, but in argparse we don't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.