gh-152433: Windows: fix ctypes error in UWP build

[thexai]

Fix ctypes error in UWP build:

In UWP is possible call GetLastError() Win32 API but not like import from ctypes with LibraryLoader:

GetLastError = windll.kernel32.GetLastError

The error produced is like this (in this case using Cryptodome):

EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
 - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <class 'AttributeError'>
Error Contents: kernel32
Traceback (most recent call last):
  File "V:\kodi-build-UWP\Debug\AppX\system\python\Lib\site-packages\Cryptodome\Util\_raw_api.py", line 83, in <module>
    raise ImportError("CFFI is not compatible with Python 3.12 on Windows")
ImportError: CFFI is not compatible with Python 3.12 on Windows

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "V:\kodi-build-UWP\Debug\AppX\system\python\Lib\ctypes\__init__.py", line 461, in __getattr__
    dll = self._dlltype(name)
  File "V:\kodi-build-UWP\Debug\AppX\system\python\Lib\ctypes\__init__.py", line 390, in __init__
    self._handle = _dlopen(self._name, mode)
                   ~~~~~~~^^^^^^^^^^^^^^^^^^
FileNotFoundError: Could not find module 'kernel32' (or one of its dependencies). Try using the full path with constructor syntax.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\Joel\AppData\Local\Packages\XBMCFoundation.Kodi_4n2hpmxwrvr6p\LocalState\addons\script.kodi.loguploader\default.py", line 1, in <module>
    from Cryptodome.Cipher import AES
  File "V:\kodi-build-UWP\Debug\AppX\system\python\Lib\site-packages\Cryptodome\Cipher\AES.py", line 26, in <module>
    from Cryptodome.Util._raw_api import (load_pycryptodome_raw_lib,
                                      VoidPointer, SmartPointer,
                                      c_size_t, c_uint8_ptr)
  File "V:\kodi-build-UWP\Debug\AppX\system\python\Lib\site-packages\Cryptodome\Util\_raw_api.py", line 170, in <module>
    import ctypes
  File "V:\kodi-build-UWP\Debug\AppX\system\python\Lib\ctypes\__init__.py", line 492, in <module>
    GetLastError = windll.kernel32.GetLastError
                   ^^^^^^^^^^^^^^^
  File "V:\kodi-build-UWP\Debug\AppX\system\python\Lib\ctypes\__init__.py", line 463, in __getattr__
    raise AttributeError(name)
AttributeError: kernel32
-->End of Python script error report<--

Since GetLastError is available from _winapi, the workaround is import from _winapi and call directly.

• Issue: Windows: improve compatibility to build for UWP / Xbox #152433

[thexai]

Ping @zooba for review

[thexai]

I've finally resolved all the issues related to ctype. The first error was due to loading kernel32 with LoadPackagedLibrary. Being able to use LoadLibrary resolved it automatically. This has been changed in #152792.

The second error was a MemoryError exception. This is because VirtualAlloc doesn't have code execution permissions in UWP. Since don't think execution permission is needed, changed also for Windows Desktop.

[chris-eibl]

LGTM. This is sitting for a while now. If nobody objects, I'm gonna merge end of next week at the latest.

[zooba]

If this works without EXECUTE, then do we need EXECUTE in the alternative VirtualAlloc call?

[thexai]

More work is needed for ctypes to have full functionality in UWP.

The EXECUTE flag is required, but in UWP, it is not allowed alongside READWRITE. This PR addresses some of the issues that recently arose after adding this code:

cpython/Modules/_ctypes/_ctypes.c

Lines 6390 to 6397 in e5d4fa2

	_ctypes_mod_exec(PyObject *mod)
	{
	// See https://github.com/python/cpython/issues/128485
	// This allocates some memory and then frees it to ensure that the
	// the dlmalloc allocator initializes itself to avoid data races
	// in free-threading.
	void *codeloc = NULL;
	void *ptr = Py_ffi_closure_alloc(sizeof(void *), &codeloc);

This causes errors immediately upon ctypes initialization (because reserves memory with execute permission).

But executing code in memory remains necessary for full ctypes functionality.

Let's say this PR only enables "limited" ctypes functionality on UWP but causes no harm on Windows Desktop.