Correct Roman-numeral example in Unicode HOWTO.#15541
Merged
Merged
Conversation
We had the character Ⅶ aka U+2166 ROMAN NUMERAL SEVEN, but the code point given is 2167 and it's next to 2168. Adjust so the code point, character, and name all agree. (This follows up on 77df9a1, which made the name match the character.) We also had a mixture of `;` and `:` for a delimiter. It doesn't really matter which, but it's good to be consistent. The actual Unicode database files use `;`, so go with that.
Contributor
|
#15536 also fixes this. |
serhiy-storchaka
approved these changes
Sep 8, 2019
Contributor
|
Thanks @gnprice for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
Contributor
|
Sorry, @gnprice and @serhiy-storchaka, I could not cleanly backport this to |
Contributor
|
Sorry @gnprice and @serhiy-storchaka, I had trouble checking out the |
serhiy-storchaka
pushed a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Sep 8, 2019
(cherry picked from commit 32a960f) Co-authored-by: Greg Price <gnprice@gmail.com>
|
GH-15728 is a backport of this pull request to the 3.8 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Sep 8, 2019
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 8, 2019
…. (pythonGH-15728) (cherry picked from commit 32a960f) Co-authored-by: Greg Price <gnprice@gmail.com> (cherry picked from commit 3be4b10) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Sep 8, 2019
Contributor
Author
|
Thanks @serhiy-storchaka for the merge and the backports! |
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had the character Ⅶ aka U+2166 ROMAN NUMERAL SEVEN, but the
code point given is 2167 and it's next to 2168. Adjust so the
code point, character, and name all agree. (This follows up on
77df9a1, which made the name match the character.)
We also had a mixture of
;and:for a delimiter.It doesn't really matter which, but it's good to be consistent.
The actual Unicode database files use
;, so go with that.