Closed
Conversation
run_embedded_interpreter() now defaults to remove_python_envvars() when no explicit env is provided, preventing PYTHONSTARTUP (e.g., set by VS Code shell integration) from leaking into the embedded interpreter and causing test failures. Also fix test_init_run_main_startup_exitcode to use remove_python_envvars() instead of dict(os.environ) as the base environment.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into test_embed failures on my machine because VS Code's shell integration sets PYTHONSTARTUP in the environment. The embedded interpreter would pick it up and run the startup script, so the output had extra text before the expected "ok! Py_RunMain() returned 123".
The fix is straightforward: run_embedded_interpreter() now calls remove_python_envvars() when no explicit env is passed, so PYTHON* variables from the parent process don't leak in. I also updated test_init_run_main_startup_exitcode to use remove_python_envvars() as its base env instead of dict(os.environ), since that test sets its own PYTHONSTARTUP and shouldn't inherit whatever happens to be in the surroundings.
Closes #157006