Skip to content

Use a PyBytesWriter for IOBase.readline - #157024

Merged
methane merged 1 commit into
python:mainfrom
methane:iobase-byteswriter
Sep 12, 2026
Merged

methane merged 1 commit into
python:mainfrom
methane:iobase-byteswriter

Conversation

@methane

@methane methane commented Sep 6, 2026

Copy link
Copy Markdown
Member

No description provided.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-06T06:21:18.924359Z 3ef65bb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@StanFromIreland StanFromIreland added the type-refactor Code refactoring (with no changes in behavior) label Sep 6, 2026
@methane
methane merged commit 0ed5fed into python:main Sep 12, 2026
59 checks passed
@methane
methane deleted the iobase-byteswriter branch September 12, 2026 07:47
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 CentOS9 NoGIL Refleaks 3.x (tier-1) has failed when building commit 0ed5fed.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1610/builds/3980) and take a look at the build logs.
  4. Check if the failure is related to this commit (0ed5fed) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1610/builds/3980

Failed tests:

  • test_free_threading

Test leaking resources:

  • test_free_threading: file descriptors
  • test_free_threading: references
  • test_free_threading: memory blocks

Summary of the results of the build (if available):

==

Click to see traceback logs
Note: switching to '0ed5fed22af7d2d917feba8cb9fb09d0bbbc4166'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 0ed5fed22af7 io: Use a PyBytesWriter for IOBase.readline (#157024)
Switched to and reset branch 'main'

configure: WARNING: no system libmpdec found; falling back to pure-Python version for the decimal module

make: *** [Makefile:2473: buildbottest] Error 2

clin1234 pushed a commit to clin1234/cpython that referenced this pull request Sep 12, 2026
johnslavik pushed a commit to johnslavik/cpython that referenced this pull request Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip issue skip news type-refactor Code refactoring (with no changes in behavior)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants