Skip to content

[3.13] Fix unused value warnings and clean up unused map() in standard library modules (GH - 157053) - #157054

Closed
evdakim1234 wants to merge 2 commits into
python:3.13from
evdakim1234:fix-issue-#157053
Closed

[3.13] Fix unused value warnings and clean up unused map() in standard library modules (GH - 157053)#157054
evdakim1234 wants to merge 2 commits into
python:3.13from
evdakim1234:fix-issue-#157053

Conversation

@evdakim1234

Copy link
Copy Markdown

Fixes #157053

Replaced unused variables with _ in Lib/_markupbase.py, Lib/idlelib/multicall.py, Lib/turtle.py to address static analysis warnings.
Remove redundant map() call in Lib/idlelib/searchengine.py

replacing unused variables with _
removed unused map() execution logic
@python-cla-bot

python-cla-bot Bot commented Sep 6, 2026

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

CLA not signed

@bedevere-app

bedevere-app Bot commented Sep 6, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@terryjreedy terryjreedy added the pending The issue will be closed if no feedback is provided label Sep 7, 2026

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be closed because

  1. The proposed changes, using _ instead of a name for unused loop variables and destructuring targets, is extremely nitpicky. Some of these have been present for over 20 years and have been ignored in previous unused name scans. I think at least some current idlelib code is better as is and I would reject the change.
  2. The PR author has obviously not read the devguide.
    a. The PR targets 3.13 instead of main (now 3.16).
    b. The title does not include the issue number.
    c. After 3 hours, the PR author has not yet signed the CLA or other wise posted anything.
    Further review effort may be useless.

@bedevere-app

bedevere-app Bot commented Sep 7, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@gvanrossum

Copy link
Copy Markdown
Member

Agreed that the issue (#157053) and the PR should be closed on account of being just code churn, not in any way improvements.

@gvanrossum gvanrossum closed this Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes pending The issue will be closed if no feedback is provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants