[3.13] Fix unused value warnings and clean up unused map() in standard library modules (GH - 157053) - #157054
[3.13] Fix unused value warnings and clean up unused map() in standard library modules (GH - 157053)#157054evdakim1234 wants to merge 2 commits into
Conversation
replacing unused variables with _
removed unused map() execution logic
|
The following commit authors need to sign the Contributor License Agreement: |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
terryjreedy
left a comment
There was a problem hiding this comment.
I think this should be closed because
- The proposed changes, using _ instead of a name for unused loop variables and destructuring targets, is extremely nitpicky. Some of these have been present for over 20 years and have been ignored in previous unused name scans. I think at least some current idlelib code is better as is and I would reject the change.
- The PR author has obviously not read the devguide.
a. The PR targets 3.13 instead of main (now 3.16).
b. The title does not include the issue number.
c. After 3 hours, the PR author has not yet signed the CLA or other wise posted anything.
Further review effort may be useless.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Agreed that the issue (#157053) and the PR should be closed on account of being just code churn, not in any way improvements. |
Fixes #157053
Replaced unused variables with
_inLib/_markupbase.py,Lib/idlelib/multicall.py,Lib/turtle.pyto address static analysis warnings.Remove redundant
map()call inLib/idlelib/searchengine.py