gh-156780: Emscripten: drop the trampoline's dependence on exports - #157238
Open
clementperon wants to merge 1 commit into
Open
gh-156780: Emscripten: drop the trampoline's dependence on exports#157238clementperon wants to merge 1 commit into
clementperon wants to merge 1 commit into
Conversation
clementperon
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland and
itamaro
as code owners
September 9, 2026 21:19
Contributor
Author
|
@freakboy3742 FYI |
hoodmane
approved these changes
Sep 9, 2026
hoodmane
left a comment
hoodmane
left a comment
Contributor
There was a problem hiding this comment.
Generally looks good to me, modulo a couple of comments.
hoodmane
approved these changes
Sep 9, 2026
hoodmane
left a comment
hoodmane
left a comment
Contributor
There was a problem hiding this comment.
Looks reasonable to me aside from a couple of comments.
clementperon
force-pushed
the
emscripten-trampoline-static
branch
3 times, most recently
from
September 10, 2026 08:19
0c9e930 to
fe2b470
Compare
The trampoline exports _PyRuntime's address itself and reuses a placeholder's table slot, so libpython no longer needs -sEXPORTED_FUNCTIONS=__PyRuntime or a growable function table. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
clementperon
force-pushed
the
emscripten-trampoline-static
branch
from
September 10, 2026 14:34
59ee601 to
0a2c8f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #156781 as requested by @hoodmane.
The call trampoline exports
_PyRuntime's address itself and takes over a placeholder's function table slot instead of callingaddFunction(), so it no longer needs_PyRuntimein-sEXPORTED_FUNCTIONSor-sALLOW_TABLE_GROWTH.__PyRuntimeis dropped from the interpreter's export list.Tested with the CI configuration: the wasm-gc trampoline is picked up and
test_capi,test_builtin,test_functoolspass.🤖 Generated with Claude Code