bpo-25597: Ensure wraps' return value is used for magic methods in MagicMock#16029
Merged
Conversation
cjw296
requested changes
Jan 26, 2020
cjw296
left a comment
cjw296
left a comment
Contributor
There was a problem hiding this comment.
Great, but the news entry needs some work, not sure my interpretation is correct?
| @@ -0,0 +1,3 @@ | |||
| Ensure ``wraps`` is supplied to :class:`unittest.mock.MagicMock` is used to | |||
| calculate return values for the magic methods instead of using the default | |||
Contributor
There was a problem hiding this comment.
"Ensure, if wraps is supplied to :class:unittest.mock.MagicMock, it is used to" maybe?
Member
Author
There was a problem hiding this comment.
Thanks Chris, updated.
|
When you're done making the requested changes, leave the comment: |
Member
Author
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @cjw296: please review the changes made to this pull request. |
cjw296
approved these changes
Jan 27, 2020
|
@cjw296: Please replace |
Member
Author
|
Thanks Chris :) |
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
tirkarthi
added a commit
to tirkarthi/cpython
that referenced
this pull request
Apr 27, 2020
…ds in MagicMock (python#16029)" This reverts commit 72b1004.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue25597