Skip to content

bpo-13743: Add some documentation strings to xml.dom.minidom#16355

Merged
scoder merged 2 commits into
python:masterfrom
alexitkes:alexitkes/xml-docstrings
Apr 12, 2020
Merged

bpo-13743: Add some documentation strings to xml.dom.minidom#16355
scoder merged 2 commits into
python:masterfrom
alexitkes:alexitkes/xml-docstrings

Conversation

@alexitkes

@alexitkes alexitkes commented Sep 24, 2019

Copy link
Copy Markdown
Contributor

Add documentation strings to some methods of the xml.dom.minidom.Element class. It would be possibly better to be able to know some small but important features of these methods directly from pydoc. The Element.getAttribute method returns an empty string both if there is no such attribute and if an empty string is an explicitly given attribute value. It never returns None. The Element.getElementsByTagName method returns all descendants, not direct children only.

https://bugs.python.org/issue13743

@corona10

Copy link
Copy Markdown
Member

Thanks for the PR @alexitkes
Please add a whats news through blurb tools.

You can follow the guide via this link.
https://devguide.python.org/committing/#what-s-new-and-news-entries

@corona10

Copy link
Copy Markdown
Member

@alexitkes
Please leave an issue on https://bugs.python.org also :)

p.s
I can find a similar issue on https://bugs.python.org
https://bugs.python.org/issue13743.

@brandtbucher brandtbucher added the docs Documentation in the Doc dir label Sep 25, 2019
@alexitkes alexitkes changed the title DOC: Add some documentation strings to xml.dom.minidom bpo-13743: Add some documentation strings to xml.dom.minidom Sep 25, 2019
@matrixise matrixise requested a review from scoder September 26, 2019 07:07
@alexitkes alexitkes force-pushed the alexitkes/xml-docstrings branch from 31dc955 to 7546705 Compare October 7, 2019 15:37
@scoder scoder merged commit 63e5b59 into python:master Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants