Skip to content

Re-enable the OverflowError test for test_truediv on test_complex - #16591

Merged
serhiy-storchaka merged 1 commit into
python:masterfrom
corona10:remove_fixme_on_test_complex
Oct 10, 2019
Merged

Re-enable the OverflowError test for test_truediv on test_complex#16591
serhiy-storchaka merged 1 commit into
python:masterfrom
corona10:remove_fixme_on_test_complex

Conversation

@corona10

@corona10 corona10 commented Oct 5, 2019

Copy link
Copy Markdown
Member

This code was added 17 years ago. It works well today.

@corona10

corona10 commented Oct 5, 2019

Copy link
Copy Markdown
Member Author

@serhiy-storchaka Please take a look

@serhiy-storchaka
serhiy-storchaka requested review from mdickinson and removed request for serhiy-storchaka October 5, 2019 09:00
@serhiy-storchaka

Copy link
Copy Markdown
Member

I think @mdickinson is more accomplished in this.

@mdickinson mdickinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corona10

Copy link
Copy Markdown
Member Author

@serhiy-storchaka
Merge this PR please :)

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2019
…thonGH-16591)

(cherry picked from commit 1dbe537)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-16703 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 10, 2019
…-16591)

(cherry picked from commit 1dbe537)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@corona10
corona10 deleted the remove_fixme_on_test_complex branch October 11, 2019 02:37
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants