bpo-38409: Grammatically correct help documentation of str.strip() - #16681
bpo-38409: Grammatically correct help documentation of str.strip()#16681hansrajdas wants to merge 3 commits into
Conversation
* `remove` should be `removed` as done for lstrip and rstrip help docs
| @@ -0,0 +1 @@ | |||
| Grammatically corrected help(str.strip) documentation. Patch by Hansraj Das | |||
There was a problem hiding this comment.
Trivial fixes like these don't need a news blurb. I'm gonna apply to the skip-news label if you wanna take it out.
There was a problem hiding this comment.
Deleted news blurb file. Thank you!
| "--\n" | ||
| "\n" | ||
| "Return a copy of the string with leading and trailing whitespace remove.\n" | ||
| "Return a copy of the string with leading and trailing whitespace removed.\n" |
There was a problem hiding this comment.
This file is automatically generated using argument clinic, you need to regenerate it using make regen-all or make clinic
There was a problem hiding this comment.
executed make clinic
…icodeobject.c.h * checksums also updated
|
Considering that this is incorrect and was taken without attribution or approval of the original author, I'm closing this in favor of GH-16682. Since the original author hasn't signed the CLA, the usability of this patch is murky anyway. Thanks for contributing, @hansrajdas, but when the reporter has offered a patch on bugs.python.org please give them a chance to either submit their own PR or refuse to do so; this one was submitted only yesterday. |
Yes, I saw this bug reported yesterday itself(maked myself in that bug also yesterday) so waited one day if original author wants to send an PR. Sorry, I should have waited more! |
|
The documented suggested wait time is one week of no response. |
Thank you @zware for guidance, I was not aware of this. Will always follow this guideline ever in future! |
removeshould beremovedas done for lstrip and rstrip help docsstrip help doc in python2 was correct but it was updated in python3:
python2.7
python3.7
https://bugs.python.org/issue38409