bpo-38539: update demo files#16890
Conversation
- changed 'while 1' usages to 'while True' - rename ss1.py
| sortvisu.py GUI programming: Visualization of different sort algorithms. | ||
| ss1.py GUI/Application programming: A simple spreadsheet application. | ||
| vector.py Python basics: A vector class with demonstrating special methods. No newline at end of file | ||
| beer.py Well-known programming example: Bottles of beer. |
There was a problem hiding this comment.
Please undo all the gratuitous whitespace changes and stick with the ones we agreed to.
There was a problem hiding this comment.
@rhettinger But when ss1.py is renamed to spreadsheet.py in the README, it will touch the next column. How should we go around that?
The original file had 4 spaces between the longest line in the first column and the second column.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
| return total | ||
|
|
||
| class Sheet: | ||
|
|
| SheetParser(self).parsefile(f) | ||
|
|
||
| class SheetParser: | ||
|
|
There was a problem hiding this comment.
@eamanu I just renamed that file. Will it be better to remove that line?
| SheetParser(self).parsefile(f) | ||
|
|
||
| class SheetParser: | ||
|
|
There was a problem hiding this comment.
@eamanu I just renamed that file. Will it be better to remove that line?
| cell = self.getcell(x, y) | ||
| if hasattr(cell, 'recalc'): | ||
| return cell.recalc(self.ns) | ||
| else: |
There was a problem hiding this comment.
@eamanu @rhettinger Can we remove this else? It is right after a return in its if.
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @rhettinger: please review the changes made to this pull request. |
5 participants
https://bugs.python.org/issue38539