Skip to content

bpo-38466: fix threading.excepthook doc that talks about "object" instead of "thread"#16891

Merged
vstinner merged 1 commit into
python:masterfrom
dlbas:bpo-38466
Oct 22, 2019
Merged

bpo-38466: fix threading.excepthook doc that talks about "object" instead of "thread"#16891
vstinner merged 1 commit into
python:masterfrom
dlbas:bpo-38466

Conversation

@dlbas

@dlbas dlbas commented Oct 22, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown

Changed mentions of object in threading.excepthook docs to thread - args parameter has thread attribute, but not object.

https://bugs.python.org/issue38466

@the-knights-who-say-ni

the-knights-who-say-ni commented Oct 22, 2019

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@MagnificentUrukHai

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 22, 2019
@vstinner vstinner closed this Oct 22, 2019
@vstinner vstinner reopened this Oct 22, 2019
@vstinner

vstinner commented Oct 22, 2019

Copy link
Copy Markdown
Member

I closed and reopened the PR since the Azure Pipelines job never started.

vstinner
vstinner approved these changes Oct 22, 2019
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner
vstinner merged commit 91528f4 into python:master Oct 22, 2019
@miss-islington

miss-islington commented Oct 22, 2019

Copy link
Copy Markdown
Contributor

Thanks @MagnificentUrukHai for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2019
Daniel Baskal @miss-islington
bpo-38466: Fix threading.excepthook doc (pythonGH-16891)
619b4ae 
(cherry picked from commit 91528f4)

Co-authored-by: Daniel Baskal <MagnificentUrukHai@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Oct 22, 2019

Copy link
Copy Markdown

GH-16894 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 22, 2019
@miss-islington Daniel Baskal
bpo-38466: Fix threading.excepthook doc (GH-16891)
6329a56 
(cherry picked from commit 91528f4)

Co-authored-by: Daniel Baskal <MagnificentUrukHai@users.noreply.github.com>
@dlbas
dlbas deleted the bpo-38466 branch October 23, 2019 07:16
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
Daniel Baskal Jake Taylor
bpo-38466: Fix threading.excepthook doc (pythonGH-16891)
7c32fc5
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Daniel Baskal @shihai1991
bpo-38466: Fix threading.excepthook doc (pythonGH-16891)
199fef2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dlbas @the-knights-who-say-ni @vstinner @miss-islington @bedevere-bot