Skip to content

bpo-38519: Internal include files missing on Windows#16921

Merged
zooba merged 2 commits into
python:masterfrom
ZackerySpytz:bpo-38519-include-files
Oct 28, 2019
Merged

bpo-38519: Internal include files missing on Windows#16921
zooba merged 2 commits into
python:masterfrom
ZackerySpytz:bpo-38519-include-files

Conversation

@ZackerySpytz

@ZackerySpytz ZackerySpytz commented Oct 25, 2019

Copy link
Copy Markdown
Contributor

@ZackerySpytz

Copy link
Copy Markdown
Contributor Author

@zooba Do you think we need a news entry for this?

@eamanu eamanu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. IMO we need NEWs

@zooba

zooba commented Oct 25, 2019

Copy link
Copy Markdown
Member

Agreed. A NEWS entry reading Restores the internal C headers that were missing from the nuget.org and Microsoft Store packages would be fine.

@zooba zooba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with NEWS entry

@ZackerySpytz

Copy link
Copy Markdown
Contributor Author

I have added a news entry.

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-16966 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 28, 2019
(cherry picked from commit edb172a)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants