Skip to content

bpo-38600: Change the mark up of NULL in the C API documentation.#16950

Merged
serhiy-storchaka merged 2 commits into
python:masterfrom
serhiy-storchaka:docs-null
Oct 30, 2019
Merged

bpo-38600: Change the mark up of NULL in the C API documentation.#16950
serhiy-storchaka merged 2 commits into
python:masterfrom
serhiy-storchaka:docs-null

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Oct 27, 2019

Copy link
Copy Markdown
Member

Replace all *NULL* with ``NULL``.

https://bugs.python.org/issue38600

Comment thread Include/abstract.h
/* Call a callable Python object 'callable' with arguments given by the
tuple 'args' and keywords arguments given by the dictionary 'kwargs'.

'args' must not be *NULL*, use an empty tuple if no arguments are

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this replacement intentional? This seems to be outside the docs.

@serhiy-storchaka
serhiy-storchaka merged commit 25fc088 into python:master Oct 30, 2019
@serhiy-storchaka
serhiy-storchaka deleted the docs-null branch October 30, 2019 10:03
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 25fc088607c855060ed142296dc1bd0125fad1af 3.8

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 25fc088607c855060ed142296dc1bd0125fad1af 3.7

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 30, 2019
…n. (pythonGH-16950)

Replace all *NULL* with ``NULL``..
(cherry picked from commit 25fc088)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 30, 2019
…n. (pythonGH-16950)

Replace all *NULL* with ``NULL``..
(cherry picked from commit 25fc088)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-16999 is a backport of this pull request to the 3.8 branch.

@bedevere-bot

Copy link
Copy Markdown

GH-17000 is a backport of this pull request to the 3.7 branch.

@serhiy-storchaka serhiy-storchaka removed their assignment Oct 30, 2019
serhiy-storchaka added a commit that referenced this pull request Oct 30, 2019
…n. (GH-16950) (GH-17000)

Replace all *NULL* with ``NULL``.
(cherry picked from commit 25fc088)
serhiy-storchaka added a commit that referenced this pull request Oct 30, 2019
…n. (GH-16950) (GH-16999)

Replace all *NULL* with ``NULL``.
(cherry picked from commit 25fc088)
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants