bpo-38613: Optimize set operations of dict keys.#16961
Merged
Merged
Conversation
Contributor
|
+1 This looks like a nice improvement. |
rhettinger
approved these changes
Nov 5, 2019
|
|
||
| tmp = _PyObject_CallMethodIdOneArg(result, &PyId_difference_update, other); | ||
| _Py_IDENTIFIER(difference_update); | ||
| PyObject *tmp = _PyObject_CallMethodIdOneArg( |
Member
There was a problem hiding this comment.
I am wondering whether calling set.difference_update(result, other) using fast call can be faster than calling result.difference_update(other). But this is for other issue.
methane
force-pushed
the
optimize-dictkeys
branch
from
29d04e3 to
86e730b
Compare
Member
|
LGTM. Sorry, forgot to approve the PR. |
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue38613