Skip to content

bpo-22367: Add open_file_descriptor parameter to fcntl.lockf()#17099

Closed
corona10 wants to merge 11 commits into
python:masterfrom
corona10:bpo-22367
Closed

bpo-22367: Add open_file_descriptor parameter to fcntl.lockf()#17099
corona10 wants to merge 11 commits into
python:masterfrom
corona10:bpo-22367

Conversation

@corona10

@corona10 corona10 commented Nov 9, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

serhiy-storchaka
serhiy-storchaka reviewed Nov 9, 2019
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition I would add a test based on the example https://www.gnu.org/software/libc/manual/html_node/Open-File-Description-Locks-Example.html

Comment thread Modules/fcntlmodule.c Outdated
Comment thread Modules/fcntlmodule.c Outdated
@corona10

corona10 commented Nov 9, 2019

Copy link
Copy Markdown
Member Author

@serhiy-storchaka

In addition I would add a test based on the example https://www.gnu.org/software/libc/manual/html_node/Open-File-Description-Locks-Example.html

Thanks for the review.
I will add unit test based on the link.

@corona10 corona10 force-pushed the bpo-22367 branch 2 times, most recently from df8640a to e69a9f6 Compare November 10, 2019 13:30
@corona10

corona10 commented Nov 10, 2019

Copy link
Copy Markdown
Member Author

@serhiy-storchaka @vstinner
I 've added the unit test based on https://www.gnu.org/software/libc/manual/html_node/Open-File-Description-Locks-Example.html.
Please take a look :)

@corona10 corona10 force-pushed the bpo-22367 branch 2 times, most recently from 96d57b8 to d6e2fc1 Compare November 10, 2019 15:12
@corona10

corona10 commented Nov 10, 2019

Copy link
Copy Markdown
Member Author

I left a question on https://bugs.python.org/issue22367 which related to the parameter name.

pitrou
pitrou reviewed Nov 10, 2019
View reviewed changes
Comment thread Doc/library/fcntl.rst Outdated
@corona10

corona10 commented Nov 13, 2019

Copy link
Copy Markdown
Member Author

@pitrou @serhiy-storchaka @vstinner

Thanks for the review.
I 've updated the PR.

@vstinner please take a look at my suggestion on https://bugs.python.org/msg356329 which suggests changing the parameter name from open_file_descriptor to open_file_description.

@corona10

corona10 commented Nov 24, 2019

Copy link
Copy Markdown
Member Author

@vstinner If you don't mind can you leave some feedback on this PR?

@corona10

corona10 commented Feb 22, 2021

Copy link
Copy Markdown
Member Author

@vstinner Let's reopen this PR when we need this feature again ;)

@corona10 corona10 closed this Feb 22, 2021
@AndrewLutomirski AndrewLutomirski mannequin mentioned this pull request Mar 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou left review comments
@vstinner vstinner Awaiting requested review from vstinner
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@corona10 @pitrou @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot