Skip to content

closes bpo-27805: Ignore ESPIPE in initializing seek of append-mode files.#17112

Merged
benjaminp merged 1 commit into
python:masterfrom
benjaminp:open-ESPIPE
Nov 12, 2019
Merged

closes bpo-27805: Ignore ESPIPE in initializing seek of append-mode files.#17112
benjaminp merged 1 commit into
python:masterfrom
benjaminp:open-ESPIPE

Conversation

@benjaminp

@benjaminp benjaminp commented Nov 12, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This change, which follows the behavior of C stdio's fdopen and Python 2's file object, allows pipes to be opened in append mode.

https://bugs.python.org/issue27805

vstinner
vstinner reviewed Nov 12, 2019
View reviewed changes
Comment thread Lib/test/test_io.py Outdated
Comment thread Misc/NEWS.d/next/Library/2019-11-11-21-43-06.bpo-27805.D3zl1_.rst Outdated
Comment thread Lib/_pyio.py Outdated
vstinner
vstinner approved these changes Nov 12, 2019
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner

vstinner commented Nov 12, 2019

Copy link
Copy Markdown
Member

I agree with backporting the change to 3.7 and 3.8.

@benjaminp

benjaminp commented Nov 12, 2019

Copy link
Copy Markdown
Contributor Author

Thank you for the review.

@benjaminp
closes bpo-27805: Ignore ESPIPE in initializing seek of append-mode f…
9d47cef 
…iles.

This change, which follows the behavior of C stdio's fdopen and Python 2's file object, allows pipes to be opened in append mode.
@benjaminp benjaminp merged commit 74fa9f7 into python:master Nov 12, 2019
@benjaminp benjaminp deleted the open-ESPIPE branch November 12, 2019 22:51
@miss-islington

miss-islington commented Nov 12, 2019

Copy link
Copy Markdown
Contributor

Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Nov 12, 2019

Copy link
Copy Markdown
Contributor

Sorry, @benjaminp, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 74fa9f723f700a342e582b5ad4b51a2c4801cd1c 3.8

@miss-islington

miss-islington commented Nov 12, 2019

Copy link
Copy Markdown
Contributor

Sorry @benjaminp, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 74fa9f723f700a342e582b5ad4b51a2c4801cd1c 3.7

@benjaminp benjaminp mentioned this pull request Nov 12, 2019
Closed
benjaminp added a commit that referenced this pull request Nov 12, 2019
@benjaminp
[3.8] closes bpo-27805: Ignore ESPIPE in initializing seek of append-…
7645aa9 
…mode files. (GH-17112)

This change, which follows the behavior of C stdio's fdopen and Python 2's file object, allows pipes to be opened in append mode..
(cherry picked from commit 74fa9f7)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
@bedevere-bot

bedevere-bot commented Nov 12, 2019

Copy link
Copy Markdown

GH-17136 is a backport of this pull request to the 3.8 branch.

benjaminp added a commit that referenced this pull request Nov 12, 2019
@benjaminp
[3.7] closes bpo-27805: Ignore ESPIPE in initializing seek of append-…
c334a43 
…mode files. (GH-17112)

This change, which follows the behavior of C stdio's fdopen and Python 2's file object, allows pipes to be opened in append mode..
(cherry picked from commit 74fa9f7)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
@bedevere-bot

bedevere-bot commented Nov 12, 2019

Copy link
Copy Markdown

GH-17137 is a backport of this pull request to the 3.7 branch.

@Gunni

Gunni commented Nov 20, 2019

Copy link
Copy Markdown

Is there any chance of getting this fix backported to 3.6?

@vstinner

vstinner commented Nov 20, 2019

Copy link
Copy Markdown
Member

Is there any chance of getting this fix backported to 3.6?

Python upstream doesn't accept bugfixes into 3.6 anymore: https://devguide.python.org/#status-of-python-branches

You may contact your favorite Linux vendor.

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@benjaminp
closes bpo-27805: Ignore ESPIPE in initializing seek of append-mode f…
c549592 
…iles. (pythonGH-17112)

This change, which follows the behavior of C stdio's fdopen and Python 2's file object, allows pipes to be opened in append mode.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@benjaminp @shihai1991
closes bpo-27805: Ignore ESPIPE in initializing seek of append-mode f…
4bcf261 
…iles. (pythonGH-17112)

This change, which follows the behavior of C stdio's fdopen and Python 2's file object, allows pipes to be opened in append mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

@benjaminp benjaminp

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@benjaminp @vstinner @miss-islington @bedevere-bot @Gunni @the-knights-who-say-ni