bpo-22367: Update test_fcntl.py for spawn process mode#17154
Merged
Conversation
corona10
added
skip issue
skip news
and removed
awaiting review
tests
corona10
force-pushed
the
bpo-22367-test-fix
branch
from
b3b7967 to
80188a4
Compare
Member
Author
|
@vstinner I've checked both Linux and mac works as expected on this test. |
corona10
changed the title
corona10
force-pushed
the
bpo-22367-test-fix
branch
from
80188a4 to
068dbbd
Compare
corona10
changed the title
corona10
changed the title
Member
Author
|
I add @zooba as the reviewer also. Since https://bugs.python.org/issue38790 was reported also. |
zooba
approved these changes
Nov 18, 2019
zooba
left a comment
zooba
left a comment
Member
There was a problem hiding this comment.
This appears to fix the tests as far as Azure Pipelines is concerned.
I have no familiarity with what this is actually doing though, so I can't say whether the test is still valid. Get a second approval besides mine before merging.
|
@ambv: Please replace |
Contributor
|
GH-17252 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 19, 2019
(cherry picked from commit 9960230) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
|
GH-17253 is a backport of this pull request to the 3.7 branch. |
vstinner
pushed a commit
that referenced
this pull request
Nov 22, 2019
vstinner
pushed a commit
that referenced
this pull request
Nov 22, 2019
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue22367