Skip to content

bpo-38722: Runpy use io.open_code()#17234

Merged
miss-islington merged 5 commits into
python:masterfrom
jsnklln:runpy_use_io_open_code
Nov 18, 2019
Merged

bpo-38722: Runpy use io.open_code()#17234
miss-islington merged 5 commits into
python:masterfrom
jsnklln:runpy_use_io_open_code

Conversation

@jsnklln

@jsnklln jsnklln commented Nov 18, 2019 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

Jason Killen added 2 commits November 15, 2019 11:11
bpo-38722: runpy should use io.open_code() instead of open()
73e69e4 
This should be working but test.test_tools is failing when
doing the full test.  Switching branches to work on something
else right now.
Merge remote-tracking branch 'upstream/master' into feature/runpy_use…
82d2e9a 
…_io_open_code
brandtbucher
brandtbucher approved these changes Nov 18, 2019
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsnklln!

@brandtbucher brandtbucher added the type-security A security issue label Nov 18, 2019
@brandtbucher

brandtbucher commented Nov 18, 2019

Copy link
Copy Markdown
Member

@zooba

taleinat
taleinat requested changes Nov 18, 2019
View reviewed changes
Comment thread Misc/NEWS.d/next/Security/2019-11-18-16-17-56.bpo-38722.x3mECW.rst Outdated
@@ -0,0 +1 @@
:mod:`runpy` now uses :meth:`io.open_code` which will trigger auditing events. No newline at end of file

@taleinat taleinat Nov 18, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open() and io.open() also trigger auditing events. And as far as I can tell, this won't change anything WRT auditing; it only allows setting an "open code hook" using PyFile_SetOpenCodeHook. So this text needs to be revised.

@jsnklln jsnklln Nov 18, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated with a better description of what the change really means/does.

@bedevere-bot

bedevere-bot commented Nov 18, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@taleinat taleinat removed the type-security A security issue label Nov 18, 2019
@taleinat taleinat changed the title bpo-38722: Runpy use io open code bpo-38722: Runpy use io.open_code() Nov 18, 2019
zooba
zooba approved these changes Nov 18, 2019
View reviewed changes

@zooba zooba left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but let's wait on the backport discussion before merging.

Edit: Missed the automerge tag - oh well :) We can still apply the backport tag if we decide to add to 3.8.1.

@miss-islington
miss-islington merged commit e243bae into python:master Nov 18, 2019
@miss-islington

miss-islington commented Nov 18, 2019

Copy link
Copy Markdown
Contributor

Thanks @jsnklln for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Nov 18, 2019

Copy link
Copy Markdown

GH-17241 is a backport of this pull request to the 3.8 branch.

@brandtbucher

brandtbucher commented Nov 18, 2019

Copy link
Copy Markdown
Member

Thanks @jsnklln!

@taleinat

taleinat commented Nov 18, 2019

Copy link
Copy Markdown
Contributor

Thanks, @zooba! Since this is apparently a security-related issue, I've backported it.

@miss-islington

miss-islington commented Nov 18, 2019

Copy link
Copy Markdown
Contributor

Thanks @jsnklln for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Nov 18, 2019

Copy link
Copy Markdown

GH-17244 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Nov 18, 2019
@miss-islington @jsnklln
bpo-38722: Runpy use io.open_code() (GH-17234)
e37767b 
https://bugs.python.org/issue38722

Automerge-Triggered-By: @taleinat
(cherry picked from commit e243bae)

Co-authored-by: jsnklln <jsnklln@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@jsnklln
bpo-38722: Runpy use io.open_code() (pythonGH-17234)
635f2f6 
https://bugs.python.org/issue38722



Automerge-Triggered-By: @taleinat
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@jsnklln @shihai1991
bpo-38722: Runpy use io.open_code() (pythonGH-17234)
5b1af09 
https://bugs.python.org/issue38722



Automerge-Triggered-By: @taleinat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taleinat taleinat taleinat requested changes
@zooba zooba zooba approved these changes
@brandtbucher brandtbucher brandtbucher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jsnklln @brandtbucher @bedevere-bot @miss-islington @taleinat @zooba @the-knights-who-say-ni