bpo-38622: Ensure ctypes audit events pass tuples as a single argument#17243
Merged
Conversation
zooba
added
type-bug
Contributor
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 18, 2019
… single argument (pythonGH-17243) (cherry picked from commit dcf1f83) Co-authored-by: Steve Dower <steve.dower@python.org>
|
GH-17245 is a backport of this pull request to the 3.8 branch. |
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only impacts PyObj_FromPtr - if the object is a tuple,
PySys_Audit(... "O", ob)will treat it as the full set of arguments (as we do elsewhere in this file deliberately). But in this case, we want it to be passed as the sole argument of the event.To repro on CPython:
_ctypes.PyObj_FromPtr(id(a_tuple))addressofshouldn't suffer the same thing, but it won't hurt to be sure. The other uses in this file are correct.https://bugs.python.org/issue38622