Skip to content

bpo-38881: choices() raises ValueError when all weights are zero#17362

Merged
rhettinger merged 3 commits into
python:masterfrom
rhettinger:zero_random_choices
Nov 23, 2019
Merged

bpo-38881: choices() raises ValueError when all weights are zero#17362
rhettinger merged 3 commits into
python:masterfrom
rhettinger:zero_random_choices

Conversation

@rhettinger

@rhettinger rhettinger commented Nov 23, 2019

Copy link
Copy Markdown
Contributor

@tim-one tim-one left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested related rephrasings.

Comment thread Doc/library/random.rst Outdated
Comment thread Doc/library/random.rst Outdated
@rhettinger
rhettinger merged commit 041d8b4 into python:master Nov 23, 2019
@rhettinger
rhettinger deleted the zero_random_choices branch November 23, 2019 10:22

@mdickinson mdickinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson

Copy link
Copy Markdown
Member

(Whoops; sorry; I had an unrefreshed view of this PR in my browser - I didn't realise this had already been merged. LGTM nevertheless ...)

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants