bpo-21063: Improve module synopsis by GeniusLearner · Pull Request #17363 · python/cpython

GeniusLearner · 2019-11-23T11:06:49Z

Cleanup synopsis of modules in documentation.

https://bugs.python.org/issue21063

CuriousLearner

I've one question mentioned inline. Rest everything looks good to me.

brettcannon

One minor improvement to (try to) make. Otherwise LGTM!

bedevere-bot · 2019-11-25T19:18:18Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Co-Authored-By: Brett Cannon <54418+brettcannon@users.noreply.github.com>

GeniusLearner · 2019-11-25T20:06:22Z

I have made the requested changes; please review again

bedevere-bot · 2019-11-25T20:06:25Z

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

CuriousLearner

LGTM 🌮

CuriousLearner · 2019-11-25T20:25:57Z

Hey @GeniusLearner

Since this is your first contribution, you can put your name in https://github.com/python/cpython/blob/master/Misc/ACKS file which contains list of contributors to the repo, if you prefer.

eamanu

LGTM.

miss-islington · 2019-11-25T22:18:02Z

Thanks @GeniusLearner for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7, 3.8.
🐍🍒⛏🤖

miss-islington · 2019-11-25T22:18:03Z

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

bedevere-bot · 2019-11-25T22:18:16Z

GH-17381 is a backport of this pull request to the 3.7 branch.

bedevere-bot · 2019-11-25T22:18:23Z

GH-17382 is a backport of this pull request to the 3.6 branch.

miss-islington · 2019-11-25T22:18:25Z

Sorry, @GeniusLearner and @brettcannon, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f8a6316778faff3991144c3aec4fa92d7b30a72b 2.7

(cherry picked from commit f8a6316) Co-authored-by: Sanchit Khurana <54467174+GeniusLearner@users.noreply.github.com>

miss-islington · 2019-11-25T22:18:59Z

Thanks @GeniusLearner for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington · 2019-11-25T22:19:02Z

Sorry @GeniusLearner and @brettcannon, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker f8a6316778faff3991144c3aec4fa92d7b30a72b 3.8

miss-islington · 2019-11-25T22:19:41Z

Thanks @GeniusLearner for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

(cherry picked from commit f8a6316) Co-authored-by: Sanchit Khurana <54467174+GeniusLearner@users.noreply.github.com>

bedevere-bot · 2019-11-25T22:19:52Z

GH-17383 is a backport of this pull request to the 3.8 branch.

brettcannon · 2019-11-25T22:22:40Z

@GeniusLearner thanks for the PR (and everyone else for the PR review)!

(cherry picked from commit f8a6316) Co-authored-by: Sanchit Khurana <54467174+GeniusLearner@users.noreply.github.com>

bpo-21063: Improve module synopsis

f8165e2

the-knights-who-say-ni added the CLA signed label Nov 23, 2019

bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 23, 2019

CuriousLearner added the skip news label Nov 23, 2019

CuriousLearner reviewed Nov 23, 2019

View reviewed changes

Comment thread Doc/distutils/apiref.rst

brettcannon self-requested a review November 25, 2019 18:32

brettcannon requested changes Nov 25, 2019

View reviewed changes

Comment thread Doc/distutils/apiref.rst Outdated

bedevere-bot removed the awaiting review label Nov 25, 2019

bedevere-bot added the awaiting changes label Nov 25, 2019

brettcannon added needs backport to 3.6 labels Nov 25, 2019

brettcannon assigned brettcannon and unassigned brettcannon Nov 25, 2019

Update Doc/distutils/apiref.rst

2976f2a

Co-Authored-By: Brett Cannon <54418+brettcannon@users.noreply.github.com>

bedevere-bot added awaiting change review and removed awaiting changes labels Nov 25, 2019

bedevere-bot requested a review from brettcannon November 25, 2019 20:06

CuriousLearner approved these changes Nov 25, 2019

View reviewed changes

eamanu approved these changes Nov 25, 2019

View reviewed changes

brettcannon approved these changes Nov 25, 2019

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Nov 25, 2019

brettcannon merged commit f8a6316 into python:master Nov 25, 2019

bedevere-bot removed the awaiting merge label Nov 25, 2019

bedevere-bot removed the needs backport to 3.7 label Nov 25, 2019

bedevere-bot removed the needs backport to 3.6 label Nov 25, 2019

miss-islington assigned brettcannon Nov 25, 2019

brettcannon added needs backport to 3.8 and removed needs backport to 2.7 labels Nov 25, 2019

brettcannon added needs backport to 3.8 and removed needs backport to 3.8 labels Nov 25, 2019

bedevere-bot removed the needs backport to 3.8 label Nov 25, 2019

miss-islington added a commit that referenced this pull request Nov 25, 2019

bpo-21063: Improve module synopsis for distutils (GH-17363)

089387e

(cherry picked from commit f8a6316) Co-authored-by: Sanchit Khurana <54467174+GeniusLearner@users.noreply.github.com>

brettcannon pushed a commit that referenced this pull request Nov 26, 2019

bpo-21063: Improve module synopsis for distutils (GH-17363) (#17381)

2f24893

(cherry picked from commit f8a6316) Co-authored-by: Sanchit Khurana <54467174+GeniusLearner@users.noreply.github.com>

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019

bpo-21063: Improve module synopsis for distutils (pythonGH-17363)

1913b11

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020

bpo-21063: Improve module synopsis for distutils (pythonGH-17363)

9b3571a

Uh oh!

Uh oh!

Conversation

GeniusLearner commented Nov 23, 2019 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CuriousLearner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

brettcannon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-bot commented Nov 25, 2019

Uh oh!

GeniusLearner commented Nov 25, 2019

Uh oh!

bedevere-bot commented Nov 25, 2019

Uh oh!

CuriousLearner left a comment

Choose a reason for hiding this comment

Uh oh!

CuriousLearner commented Nov 25, 2019

Uh oh!

eamanu left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Nov 25, 2019

Uh oh!

miss-islington commented Nov 25, 2019

Uh oh!

bedevere-bot commented Nov 25, 2019

Uh oh!

bedevere-bot commented Nov 25, 2019

Uh oh!

miss-islington commented Nov 25, 2019

Uh oh!

miss-islington commented Nov 25, 2019

Uh oh!

miss-islington commented Nov 25, 2019

Uh oh!

miss-islington commented Nov 25, 2019

Uh oh!

bedevere-bot commented Nov 25, 2019

Uh oh!

brettcannon commented Nov 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

GeniusLearner commented Nov 23, 2019 •

edited by bedevere-bot

Loading