Skip to content

bpo-39004: increment large sendfile() test timeout #17552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giampaolo merged 2 commits into from
Dec 10, 2019
Merged

bpo-39004: increment large sendfile() test timeout #17552

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98280a9
increment large sendfile() test timeout
giampaolo Dec 10, 2019
123b8c4
use support.SHORT_TIMEOUT
giampaolo Dec 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Lib/test/test_largefile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import shutil
import threading
from test.support import TESTFN, requires, unlink, bigmemtest, find_unused_port
from test.support import SHORT_TIMEOUT
import io # C implementation of io
import _pyio as pyio # Python implementation of io

Expand Down Expand Up @@ -168,7 +169,7 @@ def test_it(self):
@unittest.skipIf(not hasattr(os, 'sendfile'), 'sendfile not supported')
class TestSocketSendfile(LargeFileTest, unittest.TestCase):
open = staticmethod(io.open)
timeout = 3
timeout = SHORT_TIMEOUT

def setUp(self):
super().setUp()
Expand All @@ -184,6 +185,7 @@ def tcp_server(self, sock):
def run(sock):
with sock:
conn, _ = sock.accept()
conn.settimeout(self.timeout)
with conn, open(TESTFN2, 'wb') as f:
event.wait(self.timeout)
while True:
Expand Down