Skip to content

bpo-39822: Use NULL instead of None for empty attrib in Element.#18735

Merged
serhiy-storchaka merged 4 commits into
python:masterfrom
serhiy-storchaka:etree-null
Mar 9, 2020
Merged

bpo-39822: Use NULL instead of None for empty attrib in Element.#18735
serhiy-storchaka merged 4 commits into
python:masterfrom
serhiy-storchaka:etree-null

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Mar 2, 2020

Copy link
Copy Markdown
Member

@scoder scoder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

Comment thread Modules/_elementtree.c Outdated
@serhiy-storchaka serhiy-storchaka merged commit dccd41e into python:master Mar 9, 2020
@serhiy-storchaka serhiy-storchaka deleted the etree-null branch March 9, 2020 13:12
@serhiy-storchaka

Copy link
Copy Markdown
Member Author

Thank you for your review @scoder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants