Skip to content

bpo-39879: update language reference to specify that dict is insertion-ordered.#19027

Closed
furkanonder wants to merge 4 commits into
python:masterfrom
furkanonder:bpo-39879
Closed

bpo-39879: update language reference to specify that dict is insertion-ordered.#19027
furkanonder wants to merge 4 commits into
python:masterfrom
furkanonder:bpo-39879

Conversation

@furkanonder

@furkanonder furkanonder commented Mar 16, 2020

Copy link
Copy Markdown
Contributor

@isidentical isidentical left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

Comment thread Doc/reference/datamodel.rst Outdated
Comment thread Doc/reference/datamodel.rst Outdated
@furkanonder furkanonder requested a review from isidentical March 16, 2020 09:51
Co-Authored-By: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>

@zware zware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also my comment on the issue.

Comment thread Doc/reference/datamodel.rst Outdated
Comment thread Doc/reference/datamodel.rst Outdated
@bedevere-bot

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@furkanonder furkanonder requested a review from zware March 17, 2020 23:17
@furkanonder

Copy link
Copy Markdown
Contributor Author

It was combined with another pr. => #19006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants